Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dockerfile -- bump rust version & add build pkgs #214

Closed
wants to merge 2 commits into from
Closed

fix: dockerfile -- bump rust version & add build pkgs #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496ee86
fix: bump rust version & add build pkgs
sarmatdev Mar 30, 2024
e381a39
use cargo-chef rust image
sarmatdev Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
FROM rust:1.67-bullseye AS chef
FROM lukemathwalker/cargo-chef:latest-rust-slim-bullseye AS chef

RUN set -x \
&& apt-get -qq update \
&& apt-get -qq -y install \
clang \
cmake \
libudev-dev \
libssl-dev \
pkg-config \
zlib1g-dev

Comment on lines +3 to +11
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look fine but ill want to review the docker file to make sure these are all required (thinking about recent xz situation)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to find unnecessary packages incrementally, but all of them seems mandatory🤔

RUN cargo install cargo-chef
WORKDIR /app

Expand Down
Loading