fix: dockerfile -- bump rust version & add build pkgs #214
Conversation
|
@ralexstokes need your touch to resolve lint checks |
Dockerfile
Outdated
| @@ -1,4 +1,15 @@ | |||
| FROM rust:1.67-bullseye AS chef | |||
| FROM rust:1.77-bullseye AS chef | |||
There was a problem hiding this comment.
im not sure if this is worth the complexity but it would be great if we could just read the rust-toolchain.toml file to load the current MSRV
There was a problem hiding this comment.
I didn't found an approach to use rust version in Dockerfile, mb you can point me on some resources?
For now I added lukemathwalker/cargo-chef:latest-rust-slim-bullseye image
| RUN set -x \ | ||
| && apt-get -qq update \ | ||
| && apt-get -qq -y install \ | ||
| clang \ | ||
| cmake \ | ||
| libudev-dev \ | ||
| libssl-dev \ | ||
| pkg-config \ | ||
| zlib1g-dev |
There was a problem hiding this comment.
these look fine but ill want to review the docker file to make sure these are all required (thinking about recent xz situation)
There was a problem hiding this comment.
I've tried to find unnecessary packages incrementally, but all of them seems mandatory🤔
ralexstokes
changed the title
|
@sarmatdev looks like some new linter errors due to a new nightly version... I'll try to get to these in the next few days |
|
yeah, the docker file is outdated and needs some more dependencies... I have and expect to maintain the https://mitchellh.com/writing/nix-with-dockerfiles you should be able to use the nix flake from the repo root, so just need to update the dockerfile |
|
closing in lieu of #219 (also I took a look at the nix route above and it was a bit more complicated than I would like...) |
Bump
rustversion, required bycargo-chefIntroduced set of build packages for compilation