-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track walletconnect failed requests #6304
base: develop
Are you sure you want to change the base?
Changes from 12 commits
b1bb3fe
070e3c9
49b1363
bf5a34c
3f1d5a8
a68ce55
3d66ecb
dc99eb1
17ba093
e36e63a
7876d7c
4317310
fbf52f8
657329d
c216544
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,6 +78,8 @@ export const event = { | |
wcNewSessionApproved: 'Approved new WalletConnect session', | ||
wcShowingSigningRequest: 'Showing Walletconnect signing request', | ||
|
||
wcRequestFailed: 'wc.failed_request', | ||
|
||
nftOffersOpenedOffersSheet: 'Opened NFT Offers Sheet', | ||
nftOffersOpenedSingleOfferSheet: 'Opened NFT Single Offer Sheet', | ||
nftOffersViewedExternalOffer: 'Viewed external NFT Offer', | ||
|
@@ -167,6 +169,9 @@ export const event = { | |
// token details | ||
tokenDetailsErc20: 'token_details.erc20', | ||
tokenDetailsNFT: 'token_details.nft', | ||
|
||
// token lists (wallet, swap, send) | ||
tokenList: 'token_list', | ||
} as const; | ||
|
||
type SwapEventParameters<T extends 'swap' | 'crosschainSwap'> = { | ||
|
@@ -363,6 +368,8 @@ export type EventProperties = { | |
dappName: string; | ||
dappUrl: string; | ||
}; | ||
[event.wcRequestFailed]: { reason: string }; | ||
|
||
[event.nftOffersOpenedOffersSheet]: { | ||
entryPoint: string; | ||
}; | ||
|
@@ -694,4 +701,12 @@ export type EventProperties = { | |
eventSentAfterMs: number; | ||
available_data: { description: boolean; image_url: boolean; floorPrice: boolean }; | ||
}; | ||
|
||
[event.tokenList]: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wondering if the properties associated with this event should be distinct user properties instead. wdyt @DanielSinclair There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This approach is fine, I think. We generally just want to understand how often users are seeing assets missing metadata on various screens. We can group those back to uniques to understand number of users if we need to. |
||
screen: 'wallet' | 'swap' | 'send' | 'discover'; | ||
total_tokens: number; | ||
no_icon: number; | ||
no_price?: number; | ||
query?: string; // query is only sent for the swap screen | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want more metadata associated with the failure here? like dapp url or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @DanielSinclair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greg-schrammel Could we add a
type
here likesession_proposal | sesion_request
and then amethod
param where applicable in addition to the reason. That way we could more easily see that a certain request type or session proposal fails more than others. I tend to find thelogger.error
above many of these events are a bit easier to read than the reason; can we copy that text to be more detailed? We can pass any optional params or error messages from throws too (don't need to require for every type or method), but looks like the if conditions handle most of the error types that could be thrown