track walletconnect failed requests #6304
Conversation
| @@ -694,4 +701,12 @@ export type EventProperties = { | |||
| eventSentAfterMs: number; | |||
| available_data: { description: boolean; image_url: boolean; floorPrice: boolean }; | |||
| }; | |||
|
|
|||
| [event.tokenList]: { | |||
There was a problem hiding this comment.
wondering if the properties associated with this event should be distinct user properties instead. wdyt @DanielSinclair
There was a problem hiding this comment.
This approach is fine, I think. We generally just want to understand how often users are seeing assets missing metadata on various screens. We can group those back to uniques to understand number of users if we need to.
src/analytics/event.ts
Outdated
| @@ -363,6 +368,8 @@ export type EventProperties = { | |||
| dappName: string; | |||
| dappUrl: string; | |||
| }; | |||
| [event.wcRequestFailed]: { reason: string }; | |||
There was a problem hiding this comment.
do we want more metadata associated with the failure here? like dapp url or something
There was a problem hiding this comment.
There was a problem hiding this comment.
@greg-schrammel Could we add a type here like session_proposal | sesion_request and then a method param where applicable in addition to the reason. That way we could more easily see that a certain request type or session proposal fails more than others. I tend to find the logger.error above many of these events are a bit easier to read than the reason; can we copy that text to be more detailed? We can pass any optional params or error messages from throws too (don't need to require for every type or method), but looks like the if conditions handle most of the error types that could be thrown
…p-connection-failed-tracking
Fixes APP-####
What changed (plus any additional context for devs)
adds
wc.failed_requesteventspossible
reasons areinvalid namespaces: ${namespaces}invalid signing requestread only walletsession not foundmethod not supported: ${method}checked amplitude we can filter starts with 'invalid namespaces:', lmk if another prop would be better just for the namespaces, same applies to 'method not supported'
Screen recordings / screenshots
What to test