-
Notifications
You must be signed in to change notification settings - Fork 311
Multi-PDF document streaming #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tresf
wants to merge
2
commits into
pdfbox3
Choose a base branch
from
stream-docs
base: pdfbox3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,20 +17,27 @@ public class BookBundle extends Book { | |
|
||
private static final Logger log = LogManager.getLogger(BookBundle.class); | ||
|
||
private boolean streaming = false; | ||
private int streamAt = 0; | ||
|
||
private Printable lastPrint; | ||
private int lastStarted; | ||
|
||
public BookBundle() { | ||
super(); | ||
} | ||
|
||
public void flagForStreaming(boolean streaming) { | ||
this.streaming = streaming; | ||
} | ||
|
||
/** | ||
* Wrapper of the wrapper class so that PrinterJob implementations will handle it as proper pageable | ||
*/ | ||
public Book wrapAndPresent() { | ||
Book cover = new Book(); | ||
for(int i = 0; i < getNumberOfPages(); i++) { | ||
cover.append(new PrintingPress(), getPageFormat(i)); | ||
cover.append(new PrintingPress(streaming), getPageFormat(i)); | ||
} | ||
|
||
return cover; | ||
|
@@ -39,31 +46,53 @@ public Book wrapAndPresent() { | |
public Book wrapAndPresent(int offset, int length) { | ||
Book coverSubset = new Book(); | ||
for(int i = offset; i < offset + length && i < getNumberOfPages(); i++) { | ||
coverSubset.append(new PrintingPress(offset), getPageFormat(i)); | ||
coverSubset.append(new PrintingPress(offset, streaming), getPageFormat(i)); | ||
} | ||
|
||
return coverSubset; | ||
} | ||
|
||
|
||
/** Printable wrapper to ensure proper reading of multiple documents across spooling */ | ||
private class PrintingPress implements Printable { | ||
|
||
private boolean isStream; | ||
private int pageOffset; | ||
|
||
public PrintingPress() { | ||
this(0); | ||
public PrintingPress(boolean stream) { | ||
this(0, stream); | ||
} | ||
|
||
public PrintingPress(int offset) { | ||
public PrintingPress(int offset, boolean stream) { | ||
pageOffset = offset; | ||
isStream = stream; | ||
} | ||
|
||
@Override | ||
public int print(Graphics g, PageFormat format, int pageIndex) throws PrinterException { | ||
pageIndex += pageOffset; | ||
log.trace("Requested page {} for printing", pageIndex); | ||
|
||
if (pageIndex < getNumberOfPages()) { | ||
if (isStream) { | ||
Printable printable = getPrintable(streamAt); | ||
if (printable != lastPrint) { | ||
lastPrint = printable; | ||
lastStarted = pageIndex; | ||
} | ||
|
||
//fixme - this setup results in too many blank pages after a no_such_page | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Commenting to add to the PR's TODO listing. |
||
int result = printable.print(g, format, pageIndex - lastStarted); | ||
if (result == NO_SUCH_PAGE) { | ||
// finished the last page of this document, move to the next | ||
streamAt++; | ||
((FuturePdf.FutureWrapper)printable).sendToPast(); | ||
} | ||
if (streamAt < getNumberOfPages()) { | ||
// always return "exists" if there are more documents to print | ||
return PAGE_EXISTS; | ||
} | ||
|
||
return result; | ||
} else if (pageIndex < getNumberOfPages()) { | ||
Printable printable = getPrintable(pageIndex); | ||
if (printable != lastPrint) { | ||
lastPrint = printable; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting to add to the PR's TODO listing.