Multi-PDF document streaming #1316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate parameters into new PdfParams object
tresf
commented
May 15, 2025
| public void bringToPresent() throws IOException { | ||
| if (presentDocument == null) { | ||
| log.trace("Loading document for use"); | ||
| //TODO - include various processing handled for non streamed documents ?? |
There was a problem hiding this comment.
Commenting to add to the PR's TODO listing.
| return realWrapper.print(graphics, pageFormat, pageIndex); | ||
| } | ||
| catch(IOException ioe) { | ||
| //todo - how to handle?? |
There was a problem hiding this comment.
Commenting to add to the PR's TODO listing.
| if (docWidth <= 0) { docWidth = page.getImageableWidth(); } | ||
| if (docHeight <= 0) { docHeight = page.getImageableHeight(); } | ||
| bundle.flagForStreaming(true); | ||
| //fixme - book bundle short-circuits based on total pages, how to bypass ? |
There was a problem hiding this comment.
Commenting to add to the PR's TODO listing.
| lastStarted = pageIndex; | ||
| } | ||
|
|
||
| //fixme - this setup results in too many blank pages after a no_such_page |
There was a problem hiding this comment.
Commenting to add to the PR's TODO listing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP