Skip to content

Unifying training models #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

johnlockejrr
Copy link

Keep the full basename without extension

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Changed unsafe basename extraction:
`file_name = i.split('.')[0]` to `file_name = os.path.splitext(i)[0]`
and
`filename = n[i].split('.')[0]` to `filename = os.path.splitext(n[i])[0]`
because
`"Vat.sam.2_206.jpg` -> `Vat` instead of `"Vat.sam.2_206`
Keep safely the full basename without extension
@cneud
Copy link
Member

cneud commented May 14, 2025

Thank you @johnlockejrr, a very useful fix/addition. Am I right to assume that this supersedes #21 and #23?

@johnlockejrr
Copy link
Author

Yes! The other ones were not in full

This was referenced Jun 3, 2025
@cneud cneud merged commit d6ccb83 into qurator-spk:unifying-training-models Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants