Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce roq-frontmatter #24

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Introduce roq-frontmatter #24

merged 5 commits into from
Aug 28, 2024

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jun 26, 2024

Fixes: #29

@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 26, 2024

@mkouba goal is to remove the need for this:

@ApplicationScoped
@Path("/posts")
public static class MyResource {
@Inject
@Named("posts/article.html")
JsonObject fm;
@CheckedTemplate(basePath = "posts")
public static class Posts {
public static native TemplateInstance article(Map<String, Object> fm);
}
@GET
@Path("my-cool-page")
@Produces(MediaType.TEXT_HTML)
public TemplateInstance get() {
return Posts.article(fm.getMap());
}
}
}

Copy link

github-actions bot commented Aug 27, 2024

🙈 The PR is closed and the preview is expired.

@ia3andy ia3andy force-pushed the frontmatter branch 2 times, most recently from ffde39c to 21a7373 Compare August 28, 2024 09:23
@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 28, 2024

Ok I fixed all the tests and moved the integrations tests to root as it is testing all the extensions (frontmatter, data, generator)

@ia3andy ia3andy marked this pull request as ready for review August 28, 2024 09:27
@ia3andy ia3andy requested a review from a team as a code owner August 28, 2024 09:27
@@ -0,0 +1,7 @@
name: ROQ # add your name
Copy link
Member

@mcruzdev mcruzdev Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool in the future to have more than one author

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a standard roq data, you can add an array if you want :)

---
layout: post
title: 10 Tips To Improve Your Workflow
date: 2024-08-10 00:00:00 +0300
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to have the date in that format yyyy-MM-dd, I think is more simple, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is using Jekyll default to make it easy to port existing posts, but this will be configurable

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 28, 2024

Finally the CI is passing (linux, windows and native 😅)

@ia3andy ia3andy merged commit aaa6489 into quarkiverse:main Aug 28, 2024
4 checks passed
@ia3andy ia3andy deleted the frontmatter branch August 28, 2024 14:23
mcruzdev pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce roq-frontmatter
3 participants