Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: make it possible to supply a template backed by a build item #41391

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Qute: make it possible to supply a template backed by a build item #41391

merged 1 commit into from
Jun 26, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 24, 2024

@mkouba mkouba requested review from gastaldi and ia3andy June 24, 2024 15:00
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Jun 24, 2024
@ia3andy
Copy link
Contributor

ia3andy commented Jun 24, 2024

That was fast :)

@ia3andy
Copy link
Contributor

ia3andy commented Jun 24, 2024

I will have a look tomorrow :)

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Jun 25, 2024

I will have a look tomorrow :)

@ia3andy did you get a chance to look at it? ;-)

@mkouba mkouba requested a review from ia3andy June 26, 2024 09:04
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 26, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 74ed772.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

ia3andy
ia3andy approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is awesome, I tested it in quarkiverse/quarkus-roq#24

@gsmet gsmet merged commit e35f2fb into quarkusio:main Jun 26, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 26, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/qute The template engine kind/enhancement New feature or request
Projects
None yet
Milestone
3.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Qute: make it possible to supply a template backed by a build item
4 participants
@mkouba @ia3andy @gastaldi @gsmet