Skip to content

llm release with logging #16496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobSzwejbka wants to merge 3 commits into
base: main
Choose a base branch
from
Open

llm release with logging #16496

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dcd8dc
llm release with logging
JacobSzwejbka Jan 7, 2026
c3a0a23
logging
JacobSzwejbka Jan 15, 2026
58dfa5c
Merge branch 'main' into preset-logs
JacobSzwejbka Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 111 additions & 3 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,17 @@
"CMAKE_INSTALL_PREFIX": "${sourceDir}/cmake-out"
}
},
{
"name": "llm-release-logging",
"displayName": "LLM release build with logging enabled",
"inherits": [
"llm-release"
],
"cacheVariables": {
"EXECUTORCH_ENABLE_LOGGING": "ON",
"ET_MIN_LOG_LEVEL": "Info"
Copy link
Contributor

@manuelcandales manuelcandales Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info level is the default. You can delete this ET_MIN_LOG_LEVEL line, and it should still work

Copy link
Contributor Author

@JacobSzwejbka JacobSzwejbka Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer being verbose especially since I expect mostly LLMs will be reading/editing this file from now on.

Copy link
Contributor

@manuelcandales manuelcandales Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then use "EXECUTORCH_LOG_LEVEL": "Info"

}
},
{
"name": "llm-release-cuda",
"displayName": "LLM release build with CUDA",
Expand All @@ -160,6 +171,17 @@
"list": ["Linux", "Windows"]
}
},
{
"name": "llm-release-cuda-logging",
"displayName": "LLM release build with CUDA and logging enabled",
"inherits": [
"llm-release-cuda"
],
"cacheVariables": {
"EXECUTORCH_ENABLE_LOGGING": "ON",
"ET_MIN_LOG_LEVEL": "Info"
}
},
{
"name": "llm-release-metal",
"displayName": "LLM release build with Metal",
Expand All @@ -175,6 +197,17 @@
"rhs": "Darwin"
}
},
{
"name": "llm-release-metal-logging",
"displayName": "LLM release build with Metal and logging enabled",
"inherits": [
"llm-release-metal"
],
"cacheVariables": {
"EXECUTORCH_ENABLE_LOGGING": "ON",
"ET_MIN_LOG_LEVEL": "Info"
}
},
{
"name": "llm-debug",
"displayName": "LLM debug build",
Expand All @@ -183,7 +216,9 @@
],
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"CMAKE_INSTALL_PREFIX": "${sourceDir}/cmake-out"
"CMAKE_INSTALL_PREFIX": "${sourceDir}/cmake-out",
"EXECUTORCH_ENABLE_LOGGING": "ON",
"ET_MIN_LOG_LEVEL": "Debug"
}
},
{
Expand All @@ -193,7 +228,9 @@
"llm-debug"
],
"cacheVariables": {
"EXECUTORCH_BUILD_CUDA": "ON"
"EXECUTORCH_BUILD_CUDA": "ON",
"EXECUTORCH_ENABLE_LOGGING": "ON",
"ET_MIN_LOG_LEVEL": "Debug"
Copy link
Contributor

@manuelcandales manuelcandales Jan 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually work? did you try it and it printed Debug logs?
in my experience, I have to pass "EXECUTORCH_LOG_LEVEL": "Debug" to make it work

},
"condition": {
"lhs": "${hostSystemName}",
Expand All @@ -208,7 +245,9 @@
"llm-debug"
],
"cacheVariables": {
"EXECUTORCH_BUILD_METAL": "ON"
"EXECUTORCH_BUILD_METAL": "ON",
"EXECUTORCH_ENABLE_LOGGING": "ON",
"ET_MIN_LOG_LEVEL": "Debug"
},
"condition": {
"lhs": "${hostSystemName}",
Expand Down Expand Up @@ -294,6 +333,33 @@
],
"jobs": 0
},
{
"name": "llm-release-logging-install",
"displayName": "Build and install LLM extension release artifacts (with logging)",
"configurePreset": "llm-release-logging",
"targets": [
"install"
],
"jobs": 0
},
{
"name": "llm-release-cuda-logging-install",
"displayName": "Build and install LLM extension release artifacts (CUDA with logging)",
"configurePreset": "llm-release-cuda-logging",
"targets": [
"install"
],
"jobs": 0
},
{
"name": "llm-release-metal-logging-install",
"displayName": "Build and install LLM extension release artifacts (Metal with logging)",
"configurePreset": "llm-release-metal-logging",
"targets": [
"install"
],
"jobs": 0
},
{
"name": "llm-debug-install",
"displayName": "Build and install LLM extension debug artifacts",
Expand Down Expand Up @@ -365,6 +431,48 @@
}
]
},
{
"name": "llm-release-logging",
"displayName": "Configure, build and install ExecuTorch LLM extension with logging enabled",
"steps": [
{
"type": "configure",
"name": "llm-release-logging"
},
{
"type": "build",
"name": "llm-release-logging-install"
}
]
},
{
"name": "llm-release-cuda-logging",
"displayName": "Configure, build and install ExecuTorch LLM extension with CUDA and logging enabled",
"steps": [
{
"type": "configure",
"name": "llm-release-cuda-logging"
},
{
"type": "build",
"name": "llm-release-cuda-logging-install"
}
]
},
{
"name": "llm-release-metal-logging",
"displayName": "Configure, build and install ExecuTorch LLM extension with Metal and logging enabled",
"steps": [
{
"type": "configure",
"name": "llm-release-metal-logging"
},
{
"type": "build",
"name": "llm-release-metal-logging-install"
}
]
},
{
"name": "llm-debug",
"displayName": "Configure, build and install ExecuTorch LLM extension with default CPU backend (Debug)",
Expand Down
Loading