-
Notifications
You must be signed in to change notification settings - Fork 800
llm release with logging #16496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
llm release with logging #16496
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16496
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit 58dfa5c with merge base 5fc4312 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
| "EXECUTORCH_BUILD_CUDA": "ON" | ||
| "EXECUTORCH_BUILD_CUDA": "ON", | ||
| "EXECUTORCH_ENABLE_LOGGING": "ON", | ||
| "ET_MIN_LOG_LEVEL": "Debug" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this actually work? did you try it and it printed Debug logs?
in my experience, I have to pass "EXECUTORCH_LOG_LEVEL": "Debug" to make it work
| ], | ||
| "cacheVariables": { | ||
| "EXECUTORCH_ENABLE_LOGGING": "ON", | ||
| "ET_MIN_LOG_LEVEL": "Info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info level is the default. You can delete this ET_MIN_LOG_LEVEL line, and it should still work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer being verbose especially since I expect mostly LLMs will be reading/editing this file from now on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then use "EXECUTORCH_LOG_LEVEL": "Info"
|
i think you also need to enable logging in examples/models/parakeet/CMakePresets.json |
No description provided.