Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix possible endless wait in stop() after AUTH_FAILED error (… #744

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Revert "Fix possible endless wait in stop() after AUTH_FAILED error (… #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kazoo/protocol/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ def _connect_attempt(self, host, hostip, port, retry):
self.ping_outstanding.clear()
last_send = time.monotonic()
with self._socket_error_handling():
while not self.client._stopped.is_set():
while True:
# Watch for something to read or send
jitter_time = random.randint(1, 40) / 100.0
deadline = last_send + read_timeout / 2.0 - jitter_time
Expand Down
2 changes: 0 additions & 2 deletions kazoo/tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,6 @@ def test_async_auth_failure(self):
with pytest.raises(AuthFailedError):
client.add_auth("unknown-scheme", digest_auth)

client.stop()

def test_add_auth_on_reconnect(self):
client = self._get_client()
client.start()
Expand Down