Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix possible endless wait in stop() after AUTH_FAILED error (… #744

Merged
merged 1 commit into from
Mar 6, 2024

Commits on Mar 1, 2024

  1. fix(core): Revert "Fix possible endless wait in stop() after AUTH_FAI…

    …LED error (python-zk#688)"
    
    This reverts commit 5225b3e.
    
    The commit being reverted here caused kazoo not to empty the send
    queue before disconnecting. This means that if a client submitted
    asynchronous requests and then called client.stop(), the connection
    would be closed immediately, usually after only one (but possibly
    more) of the submitted requests were sent. Prior to this, Kazoo
    would empty the queue of submitted requests all the way up to and
    including the Close request when client.stop() was called.
    
    Another area where this caused problems is in a busy multi-threaded
    system. One thread might decide to gracefully close the connection,
    but if there is any traffic generated by another thread, then the
    connection would end up terminating without ever sending the Close
    request.
    
    Failure to gracefully shutdown a ZooKeeper connection can mean that
    other system components need to wait for ephemeral node timeouts to
    detect that a component has shutdown.
    jeblair committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2fb93a8 View commit details
    Browse the repository at this point in the history