Skip to content

Conversation

@mcepl
Copy link

@mcepl mcepl commented Dec 30, 2025

  • Add detailed JSON configuration example for enabling pylsp-rope rename
  • Clarify differences between rename plugins (pylsp_rope vs rope_rename vs jedi_rename)
  • Include verification steps and current limitations
  • Add comprehensive test suite demonstrating configuration patterns
  • Document future benefits of using pylsp-rope's rename functionality

Fixes: #29

- Add automatic documentation build and deployment to GitHub Pages
- Add rename configuration guide with examples
- Update README with concise documentation and links to RTD
- Add docs optional dependencies to pyproject.toml
- Add .readthedocs.yaml configuration file
- Add comprehensive test suite demonstrating configuration patterns of
  the rename functionality

Fixes: python-rope#29
Signed-off-by: Matěj Cepl <[email protected]>
- name: Publish package
if: startsWith(github.ref, 'refs/tags')
uses: pypa/gh-action-pypi-publish@81e9d935c883d0b210363ab89cf05f3894778450
- name: Build documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to build the docs in GitHub Actions. RTD can build the docs with just build instructions in .readthedocs.yaml, which is what the rope repository did.

If we do have some legitimate reason to build docs here, the same reason probably applies to the rope repository as well.

```bash
# Remove Rope cache
rm -rf .rope_project
rm -rf ~/.rope
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this directory exists?


```json
{
"pylsp.configurationSources": ["pycodestyle"],
Copy link
Member

@lieryan lieryan Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, configurationSources is python-lsp-server setting which has nothing to do with pylsp-rope, so mentioning it in our docs doesn't really make much sense and is distraction.

lsp-pylsp-plugins-pylsp-rope-rename t
lsp-pylsp-plugins-rope-rename-enabled nil
lsp-pylsp-plugins-jedi-rename-enabled nil)
```
Copy link
Member

@lieryan lieryan Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use emacs, so can't test, but the example config here looks suspicious. Is this really how Emacs LSP work with the LSP config key names?

- **Introduce Parameter** - Convert variables to method parameters
- **Generate Code** - Create undefined variables/functions/classes

## Editor-Specific Configuration
Copy link
Member

@lieryan lieryan Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This editor specific configuration here seems to overlap with the Rope Wiki. We should avoid duplicate documentations as that'll make it harder to maintain the docs, so either everything should go there, or everything should go here.

I kinda prefer these editor-specific docs to be documented in the Wiki since they are publicly editable, which make it easier for people outside the rope org to edit them. But as long as there's one place to document them, then it should be fine.

@mcepl
Copy link
Author

mcepl commented Dec 31, 2025 via email

@mcepl
Copy link
Author

mcepl commented Dec 31, 2025 via email

@mcepl
Copy link
Author

mcepl commented Jan 1, 2026 via email

@mcepl
Copy link
Author

mcepl commented Jan 1, 2026 via email

@mcepl
Copy link
Author

mcepl commented Jan 1, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Questions on rename features

2 participants