Skip to content

Fix parameter_option returning only the first character of attached values #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DSeaStar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix parameter_option returning only the first character of attached values #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dd97a5
Fix parameter_option returning only the first character of attached v…
SeaStar Aug 14, 2026
afce3e9
Format parameter_option tests to satisfy ruff.
SeaStar Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/434.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed `parameter_option` returning only the first character of `--option=value` and attached short-option values.
4 changes: 2 additions & 2 deletions src/cleo/io/inputs/argv_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ def parameter_option(
# For short options, test for '-o' at beginning
leading = value + "=" if value.startswith("--") else value

if token == value or (leading != "" and token.startswith(leading)):
return token[len(leading)]
if leading != "" and token.startswith(leading):
return token[len(leading) :]

return False

Expand Down
23 changes: 23 additions & 0 deletions tests/io/inputs/test_argv_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,26 @@ def test_parse_options(
i.bind(Definition(options))

assert i.options == expected_options


@pytest.mark.parametrize(
["args", "values", "expected"],
[
(["cli.py", "--directory", "/tmp/foo"], "--directory", "/tmp/foo"),
(["cli.py", "--directory=/tmp/foo"], "--directory", "/tmp/foo"),
(["cli.py", "-C", "/tmp/foo"], "-C", "/tmp/foo"),
(["cli.py", "-C/tmp/foo"], "-C", "/tmp/foo"),
(
["cli.py", "run", "--directory=/tmp/foo", "python"],
"--directory",
"/tmp/foo",
),
(["cli.py", "run", "-C/tmp/foo", "python"], "-C", "/tmp/foo"),
],
)
def test_parameter_option_returns_full_attached_value(
args: list[str], values: str, expected: str
) -> None:
i = ArgvInput(args)

assert i.parameter_option(values) == expected