Fix parameter_option returning only the first character of attached values - #538
Open
DSeaStar wants to merge 2 commits into
Open
Fix parameter_option returning only the first character of attached values#538DSeaStar wants to merge 2 commits into
DSeaStar wants to merge 2 commits into
Conversation
…alues. ArgvInput.parameter_option used token[len(leading)] instead of a slice, so --directory=/tmp/foo and -C/tmp/foo each returned a single character. This matches Symfony's substr() and unblocks poetry run --directory=path.
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434.
ArgvInput.parameter_option()treated an attached value as a single character:So
--directory=/tmp/foobecame/and-C/tmp/foobecame/. Space-separated forms (--directory /tmp/foo) already worked because they take the next token.This is the same slice Symfony uses (
substr($token, strlen($leading))). Poetry reads--directory/-Cthrough this helper before the command is fully parsed, which is whypoetry run --directory=path python file.pyfailed whilepoetry run --directory path python file.pysucceeded.Test plan
pytest tests/io/inputs/test_argv_input.py(covers--option=value,-Ovalue, space-separated forms, andrun --directory=path)pytest tests(one pre-existing TTY decoration failure unrelated to this change)