Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

become a full package... and return not defer.returnValue() #184

Merged
merged 12 commits into from
Aug 16, 2024

Conversation

altendky
Copy link
Member

#183

(thanks hynek!)

@altendky altendky changed the title return not defer.returnValue() become a full package... and return not defer.returnValue() Aug 11, 2024
@altendky
Copy link
Member Author

So the new syntax return something that replaces defer.returnValue(something) is not compatible (at a syntax level) with py2. Probably obvious to those that have thought about the point of defer.returnValue() recently, but I'm being explicit, and had to rediscover this myself. So either we can drop py2, which would presumably not be horrible, or we can have separate files. This could easily be the final straw for py2 support here, but I really prefer having a package instead of a single file anyways so it's kind of an excuse for that transformation.

@hynek
Copy link

hynek commented Aug 12, 2024

Given that Twisted has dropped Python 2 forever ago and the older pytest-twisted plugins work with old versions, I see no reasons against dropping everything up to 3.8.

@altendky
Copy link
Member Author

https://github.com/pytest-dev/pytest-twisted#python-2-support-plans

Yeah, it would be quite reasonable to drop py2. Most of this change is just me finally making the project form I prefer. Then a little is py2-compat silliness. If I end up having to monkey around with the duplicated code much then the annoyance will grow on me.

@altendky altendky merged commit dc67544 into main Aug 16, 2024
107 checks passed
@altendky altendky deleted the less_return_value branch August 16, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants