Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twisted 24.7 is deprecating twisted.internet.defer.returnValue #183

Open
hynek opened this issue Jul 31, 2024 · 3 comments
Open

Twisted 24.7 is deprecating twisted.internet.defer.returnValue #183

hynek opened this issue Jul 31, 2024 · 3 comments

Comments

@hynek
Copy link

hynek commented Jul 31, 2024

When running a test suite under Twisted 24.7.0rc1, I get a lot of:

pytest_twisted.py:424: DeprecationWarning: twisted.internet.defer.returnValue was deprecated in Twisted 24.7.0rc1; please use standard return statement instead

Looks like it's used in two places:

defer.returnValue(result)

and

defer.returnValue(arg_value)

@altendky
Copy link
Member

Thanks for the heads up on this. I just last night got back from a two week vacation. With #184 (comment) in mind, any opinions? Or, if you use pytest-twisted somewhere, could you check if this breaks everything for you?

@jpmckinney
Copy link

I only use non-end-of-life Python versions, and a plain return works in those versions.

@altendky
Copy link
Member

I blazed my own path and (after forgetting for a couple weeks, sorry) just published https://pypi.org/project/pytest-twisted/1.14.3/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants