python312Packages.twisted: 24.3.0 -> 24.7.0 #335112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
dotlambda
changed the title
dotlambda
force-pushed
the
python3Packages.incremental
branch
from
2cbf495
to
566e97e
Compare
nixpkgs-review disagrees with the rebuild count hard. @ofborg eval |
|
I'm aware of the following breakages:
|
|
Picked the systembridge package updates into #335249. |
|
@ofborg build buildbot |
dotlambda
force-pushed
the
python3Packages.incremental
branch
from
54e9d1a
to
44e3992
Compare
My nixpkgs-review says
|
dotlambda
force-pushed
the
python3Packages.incremental
branch
from
44e3992
to
720fee1
Compare
|
Result of 78 packages marked as broken and skipped:
368 packages failed to build:
1304 packages built:
|
|
Successfully built |
|
Result of 78 packages marked as broken and skipped:
176 packages failed to build:
1496 packages built:
|
|
I'll merge in a few hours unless someone objects. |
mweinelt
reviewed
Aug 19, 2024
|
Bisect says that 44d500c It used to fail as (at 00e2295): Do you know why it fails now with comparison failure instead? |
|
The Python 2 version of |
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Aug 31, 2024
Without the change the eval fails as:
$ nix-instantiate -A pypy27Packages.incremental
error:
… while evaluating the attribute 'drvPath'
at lib/customisation.nix:365:7:
364| in commonAttrs // {
365| drvPath = assert condition; drv.drvPath;
| ^
366| outPath = assert condition; drv.outPath;
… while evaluating the attribute 'drvPath'
at lib/customisation.nix:365:7:
364| in commonAttrs // {
365| drvPath = assert condition; drv.drvPath;
| ^
366| outPath = assert condition; drv.outPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:34:12:
33|
34| strict = derivationStrict drvAttrs;
| ^
35|
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: cannot coerce a set to a string: { scripts = «thunk»; }
NixOS#335112 (comment)
suggests that "The Python 2 version of buildPythonPackage doesn't support
optional-dependencies outside of passthru."
Added `passthru` explicitly.
13 tasks
|
Proposed thea addition of |
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Aug 31, 2024
Without the change the eval fails as:
$ nix-instantiate -A pypy2Packages.python-engineio-v3
error:
… while evaluating the attribute 'drvPath'
at lib/customisation.nix:365:7:
364| in commonAttrs // {
365| drvPath = assert condition; drv.drvPath;
| ^
366| outPath = assert condition; drv.outPath;
… while evaluating the attribute 'drvPath'
at lib/customisation.nix:365:7:
364| in commonAttrs // {
365| drvPath = assert condition; drv.drvPath;
| ^
366| outPath = assert condition; drv.outPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:34:12:
33|
34| strict = derivationStrict drvAttrs;
| ^
35|
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: cannot coerce a set to a string: { asyncio_client = «thunk»; client = «thunk»; }
NixOS#335112 (comment) suggests that "The Python 2 version of buildPythonPackage doesn't support optional-dependencies outside of passthru."
Added `passthru` explicitly.
13 tasks
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Aug 31, 2024
Without the change the eval fails as:
$ nix-instantiate -A pypy2Packages.python-socketio-v4 --show-trace
error:
… while evaluating the attribute 'drvPath'
at lib/customisation.nix:365:7:
364| in commonAttrs // {
365| drvPath = assert condition; drv.drvPath;
| ^
366| outPath = assert condition; drv.outPath;
… while evaluating the attribute 'drvPath'
at lib/customisation.nix:365:7:
364| in commonAttrs // {
365| drvPath = assert condition; drv.drvPath;
| ^
366| outPath = assert condition; drv.outPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:34:12:
33|
34| strict = derivationStrict drvAttrs;
| ^
35|
… while evaluating derivation 'pypy2.7-python-socketio-v4-4.6.1'
whose name attribute is located at pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'optional-dependencies' of derivation 'pypy2.7-python-socketio-v4-4.6.1'
at pkgs/development/python-modules/python-socketio-v4/default.nix:31:3:
30|
31| optional-dependencies = {
| ^
32| client = [
error: cannot coerce a set to a string: { asyncio_client = «thunk»; client = «thunk»; }
NixOS#335112 (comment) suggests that "The Python 2 version of buildPythonPackage doesn't support optional-dependencies outside of passthru."
Added `passthru` explicitly.
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://github.com/twisted/twisted/blob/twisted-24.7.0/NEWS.rst
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.