Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixng a bug in CCC #347

Merged
merged 1 commit into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/classes/test_combinatorial_complex.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,24 @@ def test_init_from_networkx_graph(self):

assert "a" in CCC.cells

def test_node_membership(self):
"""Test creation of _node_membership dictionary."""
CCC = CombinatorialComplex()
CCC.add_cell([1, 2, 3], rank=1)
CCC.add_cell([1, 2, 3, 4], rank=2)

assert 1 in CCC._node_membership
assert 2 in CCC._node_membership
assert 3 in CCC._node_membership
assert 4 in CCC._node_membership
assert frozenset({1, 2, 3, 4}) in CCC._node_membership[1]
assert frozenset({1, 2, 3}) in CCC._node_membership[1]
assert frozenset({1, 2, 3, 4}) in CCC._node_membership[2]
assert frozenset({1, 2, 3}) in CCC._node_membership[2]
assert frozenset({1, 2, 3, 4}) in CCC._node_membership[3]
assert frozenset({1, 2, 3}) in CCC._node_membership[3]
assert frozenset({1, 2, 3, 4}) in CCC._node_membership[4]

def test_add_cell(self):
"""Test adding a cell to a CCC."""
CCC = CombinatorialComplex()
Expand Down
4 changes: 4 additions & 0 deletions toponetx/classes/combinatorial_complex.py
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,10 @@ def _add_hyperedge_helper(self, hyperedge_, rank, **attr):
else:
self._complex_set.hyperedge_dict[rank][hyperedge_].update(**attr)
self._add_nodes_of_hyperedge(hyperedge_)
for i in hyperedge_:
if i not in self._node_membership:
self._node_membership[i] = set()
self._node_membership[i].add(hyperedge_)

def _CCC_condition(self, hyperedge_, rank):
"""Check if hyperedge_ satisfies the CCC condition.
Expand Down
Loading