fixng a bug in CCC #347
Merged
fixng a bug in CCC #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 97.06% 97.23% +0.17%
==========================================
Files 35 35
Lines 3507 3511 +4
==========================================
+ Hits 3404 3414 +10
+ Misses 103 97 -6 ☔ View full report in Codecov by Sentry. |
ffl096
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCC condition is not being checked correctly when inserting a new cell. Bug fixed with this PR. See #315.
Also added a new test to insure this the membership dictionary is being populated correctly, this is implemented to prevent deleting the parts of the code responsible for taking into account this feature.