Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved docstring of to_netcdf (issue #7127) #7947

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

vallirep
Copy link
Contributor

@welcome
Copy link

welcome bot commented Jun 27, 2023

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

xarray/core/dataset.py Outdated Show resolved Hide resolved
@TomNicholas
Copy link
Member

Thank you @vallirep ! We normally add an entry to whats-new.rst describing the change but it's not mandatory for a small change like this :)

@TomNicholas TomNicholas added topic-documentation topic-metadata Relating to the handling of metadata (i.e. attrs and encoding) labels Jun 27, 2023
@headtr1ck headtr1ck added the plan to merge Final call for comments label Jul 9, 2023
@dcherian
Copy link
Contributor

dcherian commented Jul 21, 2023

Sorry for the delay here @vallirep . Thanks for the contribution. Welcome to Xarray!

xarray/core/dataset.py Outdated Show resolved Hide resolved
@dcherian dcherian merged commit 971be10 into pydata:main Jul 21, 2023
25 of 26 checks passed
@welcome
Copy link

welcome bot commented Jul 21, 2023

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

dcherian added a commit to dcherian/xarray that referenced this pull request Jul 24, 2023
…lazy-array

* upstream/main: (153 commits)
  Add HDF5 Section to read/write docs page (pydata#8012)
  [pre-commit.ci] pre-commit autoupdate (pydata#8014)
  Update interpolate_na in dataset.py (pydata#7974)
  improved docstring of to_netcdf (issue pydata#7127) (pydata#7947)
  Expose "Coordinates" as part of Xarray's public API (pydata#7368)
  Core team member guide (pydata#7999)
  join together duplicate entries in the text `repr` (pydata#7225)
  Update copyright year in README (pydata#8007)
  Allow opening datasets with nD dimenson coordinate variables. (pydata#7989)
  Move whats-new entry
  [pre-commit.ci] pre-commit autoupdate (pydata#7997)
  Add documentation on custom indexes (pydata#6975)
  Use variable name in all exceptions raised in `as_variable` (pydata#7995)
  Bump pypa/gh-action-pypi-publish from 1.8.7 to 1.8.8 (pydata#7994)
  New whatsnew section
  Remove future release notes before this release
  Update whats-new.rst for new release (pydata#7993)
  Remove hue_style from plot1d docstring (pydata#7925)
  Add new what's new section (pydata#7986)
  Release summary for v2023.07.0 (pydata#7979)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments topic-documentation topic-metadata Relating to the handling of metadata (i.e. attrs and encoding)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that Variable.encoding is ignored if encoding is given in to_netcdf
4 participants