Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a compilation error with gcc 14 fixed #5208

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

wenqing
Copy link
Contributor

@wenqing wenqing commented Jun 28, 2024

Description

Fixes #5206, which is caused by a missed header algorithm .

Suggested changelog entry:

A missing ``#include <algorithm>`` in pybind11/typing.h was added to fix build errors (in case user code does not already depend on that include).

@InvincibleRMC
Copy link
Contributor

Should gcc 14 be added to the CI matrix?

@rwgk
Copy link
Collaborator

rwgk commented Jun 28, 2024

Thanks!

@rwgk rwgk merged commit 51c2aa1 into pybind:master Jun 28, 2024
86 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 28, 2024
@rwgk
Copy link
Collaborator

rwgk commented Jun 28, 2024

Should gcc 14 be added to the CI matrix?

Oh, yes.

Sorry looks like I was too fast.

But: Maybe it's not actually GCC 14 specific? But related to what other includes are in user code?

@rwgk
Copy link
Collaborator

rwgk commented Jun 28, 2024

What I mean: What's really missing is automatic checks for IWYU correctness. (I think it's a difficult project to add that.)

@InvincibleRMC
Copy link
Contributor

What I mean: What's really missing is automatic checks for IWYU correctness. (I think it's a difficult project to add that.)

Makes sense

@rwgk
Copy link
Collaborator

rwgk commented Jun 28, 2024

If someone wants to work on IWYU, this is what we use Google-internally:

google/pybind11clif#30113

I GUESS we could run https://clangd.llvm.org/design/include-cleaner under GHA. I never got a chance to look any deeper.

For completeness: Google-internally the pybind11 client code is kept IWYU clean, but pybind11 itself is not. (That would have to happen here.)

wenqing added a commit to wenqing/pybind11 that referenced this pull request Jul 6, 2024
fixes a compilation error with gcc 14.
wenqing added a commit to wenqing/pybind11 that referenced this pull request Jul 6, 2024
fixes a compilation error with gcc 14.
tranqui added a commit to tranqui/active-model-bplus that referenced this pull request Jul 8, 2024
henryiii pushed a commit that referenced this pull request Aug 12, 2024
@henryiii henryiii changed the title Fixed a compilation error with gcc 14 fix: a compilation error with gcc 14 fixed Aug 12, 2024
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Aug 13, 2024
henryiii pushed a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Typing.h not working with gcc-14 (line 104)
4 participants