Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog entry for PR #5208 #5227

Closed
wants to merge 1 commit into from
Closed

Conversation

wenqing
Copy link
Contributor

@wenqing wenqing commented Jul 6, 2024

Description

This PR adds the missed changelog entry for PR #5208.

Suggested changelog entry:

* A missing ``#include <algorithm>`` in pybind11/typing.h was added, to
  fix a GCC 14 build error.
  `#5200 <https://github.com/pybind/pybind11/pull/5208>`_

fixes a compilation error with gcc 14.
@rwgk
Copy link
Collaborator

rwgk commented Jul 6, 2024

Thanks @wenqing but this will be handled semi-automatically when we make future releases. The Changelog entries are harvested from the PR descriptions (and then maybe hand-curated in bulk). Look for make_changelog here:

https://github.com/pybind/pybind11/blob/bb05e0810b87e74709d9f4c4545f1f57a1b386f5/docs/release.rst

@rwgk rwgk closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants