fix(smart_holder): Use std::default_delete.

Ensures `std::default_delete<T>` is used to look up the deleter for a type instead of `delete` directly.
pybind · Nov 6, 2023 · 45ef975 · 45ef975
1 parent edfaaed
commit 45ef975
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/include/pybind11/detail/smart_holder_poc.h b/include/pybind11/detail/smart_holder_poc.h
@@ -103,7 +103,7 @@ struct guarded_delete {
 
 template <typename T, typename std::enable_if<std::is_destructible<T>::value, int>::type = 0>
 inline void builtin_delete_if_destructible(void *raw_ptr) {
-    delete static_cast<T *>(raw_ptr);
+    std::default_delete<T>{}(static_cast<T *>(raw_ptr));
 }
 
 template <typename T, typename std::enable_if<!std::is_destructible<T>::value, int>::type = 0>