Skip to content

Commit

Permalink
[smart_holder] type_caster_odr_guard MSVC 193732825 C++17 windows-202…
Browse files Browse the repository at this point in the history
…2 is failing for unknown reasons. (#4918)

* MSVC 193732825 C++17 windows-2022 is failing for unknown reasons.

* Bug fix: Need to test `_MSC_FULL_VER` (not `_MSC_VER`).
  • Loading branch information
Ralf W. Grosse-Kunstleve committed Nov 3, 2023
1 parent fb79bc8 commit edfaaed
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion include/pybind11/detail/descr.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,15 @@ PYBIND11_NAMESPACE_BEGIN(detail)
// violations in binaries that are otherwise already fully tested and assumed to be healthy.
//
// * MSVC 2017 does not support __builtin_FILE(), __builtin_LINE().
// * MSVC 193732825 C++17 windows-2020 is failing for unknown reasons.
// * Intel 2021.6.0.20220226 (g++ 9.4 mode) __builtin_LINE() is unreliable
// (line numbers vary between translation units).
#if defined(PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE) \
&& !defined(PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD) && defined(PYBIND11_CPP17) \
&& !defined(__INTEL_COMPILER) \
&& (!defined(_MSC_VER) || _MSC_VER >= 1920) // MSVC 2019 or newer.
&& (!defined(_MSC_VER) \
|| (_MSC_VER >= 1920 /* MSVC 2019 or newer */ \
&& (_MSC_FULL_VER != 193732825 || defined(PYBIND11_CPP20))))
# define PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD
#endif

Expand Down

0 comments on commit edfaaed

Please sign in to comment.