Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.11 #217

Merged
merged 3 commits into from
Aug 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.11"

- name: Install Poetry
run: |
pipx install poetry --python=python3.10
pipx install poetry --python=python3.11

- name: Poetry caches
uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ jobs:
uses: docker/build-push-action@v4
with:
# See Dockerfile.build for instructions on bumping this.
tags: ewjoachim/python-coverage-comment-action-base:v1
tags: ewjoachim/python-coverage-comment-action-base:v2
push: true
file: Dockerfile.build
4 changes: 2 additions & 2 deletions .github/workflows/e2e-external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.11"

- name: Install Poetry
run: |
pipx install poetry --python=python3.10
pipx install poetry --python=python3.11

- name: Poetry caches
uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
default_language_version:
python: python3.10
python: python3.11

ci:
# Renovate updates the file. We can't disable pre-commit CI's autoupdate entirely
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ You're welcome to contribute, though I can't promise the experience will be as s

### Things to know:

- Python3.10
- Python3.11
- Use [Poetry](https://python-poetry.org/)
- Launch tests with `pytest`, config is in setup.cfg
- `black`, `isort`, `flake8` and once mypy will work with 3.10, we'll use it. There's `pre-commit`, so you can install hooks with `pre-commit install`.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# See Dockerfile.build for instructions on bumping this.
FROM ewjoachim/python-coverage-comment-action-base:v1
FROM ewjoachim/python-coverage-comment-action-base:v2

COPY coverage_comment ./coverage_comment
RUN pip install .
3 changes: 1 addition & 2 deletions Dockerfile.build
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# - Dockerfile
# - .github/workflows/docker.yml

FROM python:3.10-slim
FROM python:3.11-slim

RUN set -eux; \
apt-get update; \
Expand All @@ -15,7 +15,6 @@ RUN git config --system --add safe.directory '*'
WORKDIR /workdir

COPY pyproject.toml ./
COPY poetry.lock ./
kieferro marked this conversation as resolved.
Show resolved Hide resolved
COPY coverage_comment ./coverage_comment
ENV PIP_DISABLE_PIP_VERSION_CHECK=1
ENV PIP_ROOT_USER_ACTION=ignore
Expand Down
Loading