Upgrade to Python 3.11 #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
End-to-end public repo |
kieferro
approved these changes
Jul 29, 2023
ewjoachim
force-pushed
the
py311
branch
2 times, most recently
from
d137312
to
f2b0b25
Compare
|
I've cheated and manually pushed the v2 to docker. So if the CI is green, I guess we should be all good. |
|
Tests are failing because we're matching on an exception and py3.11 exceptions are improved :) |
kieferro
reviewed
Jul 31, 2023
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
|
All good then ? |
|
Yes, looks good @ewjoachim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 commits. I think I'll need to isolate the 1st commit into its own branch, then merge it to let the CI create the v2 image, and then launch the CI for the rest of the PR and test everything. I wanted your opinion before doing anything too harsh @kieferro . Of course, this can wait until after the other ongoing PRs.