-
Notifications
You must be signed in to change notification settings - Fork 146
WIP: Redesign pwn.college #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ee85394
to
6fbe475
Compare
- Remove debugging console.log statements throughout frontend - Keep essential error/warning logging intact - Fix SSR error by adding document availability check in DojoWorkspaceLayout - Prevent "document is not defined" error during server-side rendering 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Zen mode recording_2025-09-26_04.04.42.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I've really reviewed right now is backend changes, which it would be great to split out into a separate PR.
Specifically this includes:
ctfd/patches
(with the discussed changes)dojo_plugin
Within the plugin, I don't think we want:
dojo_plugin/utils/workspace.py
changes (at least right now).dojo_plugin/utils/stats.py
changes toget_dojo_stats
(we need the early return for performance reasons, it's intentionally disabled until we find a better solution).dojo_plugin/api/v1/search.py
changes (we don't want links to change).
And of course with consideration of all the comments :)
"HOME": "/home/hacker", | ||
"PATH": env_path, | ||
"SHELL": f"{dojo_bin_path}/bash", | ||
"SHELL": f"{dojo_bin_path}/fish", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not bring this in for now.
As I said in our chat, we're going to try to integrate like this:
The third is going to ultimately require some modifications, for example we unfortunately can't change the default shell to fish (but I'd be happy to have support for a user to be able to change their default shell). And of course, since I haven't said it enough, this is really super awesome stuff! Super excited about all the work you're putting in! |
Thanks for the review and comments! Will address everything mentioned here and have a new PR for just the backend changes |
@ConnorNelson I created a new PR for the backend portion, addressing all backend comments you left |
Relevant Issues:
#783
Overview
This update gives the dojo platform a major refresh.
The workspace now feels smoother and more polished, with fullscreen mode, floating navigation, and faster loading. A new theme system ties everything together with multiple color schemes and consistent styling across the terminal, VSCode, and the rest of the UI.
Key Highlights
WIP:
Note
deploy-local
Deploy script i use locally (should be removed and envs should be defined somewhere else)Demo
https://app.dlock.tech/
Screenshots / Videos