Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support neovim #77

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Support neovim #77

merged 1 commit into from
Jan 19, 2020

Conversation

puremourning
Copy link
Owner

@puremourning puremourning commented Jan 8, 2020

Fixes #29

  • Remove bindeval: Instead, require a send function in the job/channel API, and marshal the arguments through global variables.
  • Abstract terminal API
  • Abstract job API

TODO:

  • Fix SetUpCommandBuffer so that the output of the command actually appears in the buffer in neovim. Don't understand why this doesn't work
  • Abstract channel api
  • replace WinBar in code view ? Or just rely on mappings ? Maybe a help window ?
  • replace winbar in output view with :VimspectorShowOutput <tab complete cetegory>
  • find a way to make :Vimspector... commands discoverable ?
  • add :VimspectorEval <tab complete expr> and :VimspectorWatch <tab complete expr>
  • add :VimscpectorReset

Might decide nvim is "best effort" basis only. If not, will need to:

  • add neovim jobs to CI (docker images, versions, yada yada)
  • port the whole test framework to neovim
  • write a lot more tests. there aren't enough tests to support 2 runtimes yet.

Known issues:

  • can't set environment variables when starting jobs in neovim (only in neovim master)

But, here's vimspector "working" in neovim:

asciicast

@puremourning
Copy link
Owner Author

This change is Reviewable

@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2020

This pull request introduces 1 alert and fixes 1 when merging a553b5f into 68c47ed - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 1 for Modification of parameter with default

@puremourning puremourning force-pushed the neovim branch 2 times, most recently from c5c030a to bf2718f Compare January 8, 2020 14:39
@puremourning puremourning changed the title Remove use of bindeval() as it is not suported in neovim Support neovim Jan 8, 2020
@puremourning puremourning mentioned this pull request Jan 9, 2020
3 tasks
@puremourning puremourning added the help wanted Extra attention is needed label Jan 19, 2020
Copy link
Owner Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 18 files reviewed, all discussions resolved

Copy link
Owner Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 18 files at r1, 2 of 2 files at r3, 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Owner Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Owner Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@srillia
Copy link

srillia commented Dec 14, 2020

neovim open debug mode ,watcher can't write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support neovim
2 participants