-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support neovim #30
Conversation
Hi. Is there anything I can do to help with this PR? I'm interested in neovim and windows support. |
We discussed this in Gitter, but right now the level of polly fill required to make Neovim support the features of Vim that Vimspector uses is disappointing. We either need neovim to support them (prompt buffers, WinBar) or alternative UI paradigms for these elements. I don't really want pages of vimscript that only runs in neovim because my testing burden is too high to support that, as I don't use neovim (unless we have super solid CI tests for it etc., but that's a big enough job, and of course the testing framework that I have doesn't work with neovim). Regarding windows support - PRs are welcome to support windows, and get the tests running in Azure. Not that much is required (probably mostly path related). |
Ah. Ok, I'll go check that thread out. Thanks! |
Not sure either. I don’t really follow the neovim model anymore. It’s become just a fork which is just a shame from plugin community perspective. If anyone wants to get vimspector and neovim working together in harmony and volunteer to permanently maintain that then we can chat on gitter but I personally don’t have the impetus to do so. |
Yea. It's a shame. There are real merits to neovim I think. Fingers crossed that those patches get pulled in with an upcoming neovim release. |
Hey guys, just wanted to share with you the fact that I've tried testing neovim/neovim#10433 by checking it out and build Neovim locally with it merged. It seems it should be possible to use a custom build of Neovim and with this PR merged as well it can work out. But there seems there's still some work left to be done here. I'm trying to let them know that merging it will be extremely beneficial for us. (neovim/neovim#10433 (comment)) Checking out this PR and testing with the new Neovim binary and pressing F5 gave me the following error:
|
It seems like something silly. Have you run checkhealth provider? |
Yes:
BTW pynvim 0.4.0 was released less then an hour ago. |
@romgrk @doronbehar @jpfeiffer16 thanks for all of your contributions on this. I am closing this in favour of #77, though i certainly used this for inspiration, along with comments on #52 . There's a |
Closes #29
Work in progress.
Tasks:
bindeval