Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rubocop gems to resolve jruby failures #357

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Pin rubocop gems to resolve jruby failures #357

merged 1 commit into from
Jun 20, 2024

Commits on Jun 19, 2024

  1. Fix rubocop errors

    Recent rubocop updates broke the resource_api's CI:
    
    ```ruby
    ➜  puppet-resource_api git:(main) bundle exec rubocop
    Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not.
    + set +x
    ➜  puppet-resource_api git:(main)
    ```
    
    Although the fix for other repositories was to upgrade rubocop, an upgrade was not possible on this repo because of the `jruby` and `ruby` engine testing.  The solution was to pin the rubocop dependencies to the last working nightly versions:
    
    ```ruby
    gem 'rubocop', '~> 1.48.1', require: false
    gem 'rubocop-rspec', '~> 2.20.0', require: false
    gem 'rubocop-performance', '~> 1.17.1', require: false
    ```
    
    Signed-off-by: Gavin Didrichsen <[email protected]>
    gavindidrichsen committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    efcb8bd View commit details
    Browse the repository at this point in the history