Pin rubocop gems to resolve jruby failures #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavindidrichsen
added
the
maintenance
Recent rubocop updates broke the resource_api's CI: ```ruby ➜ puppet-resource_api git:(main) bundle exec rubocop Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not. + set +x ➜ puppet-resource_api git:(main) ``` Although the fix for other repositories was to upgrade rubocop, an upgrade was not possible on this repo because of the `jruby` and `ruby` engine testing. The solution was to pin the rubocop dependencies to the last working nightly versions: ```ruby gem 'rubocop', '~> 1.48.1', require: false gem 'rubocop-rspec', '~> 2.20.0', require: false gem 'rubocop-performance', '~> 1.17.1', require: false ``` Signed-off-by: Gavin Didrichsen <[email protected]>
gavindidrichsen
force-pushed
the
fix_rubocop
branch
from
c2eb853
to
efcb8bd
Compare
joshcooper
approved these changes
Jun 19, 2024
gavindidrichsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent rubocop updates broke the resource_api's CI:
Although the fix for other repositories was to upgrade rubocop, an upgrade was not possible on this repo because of the
jrubyandrubyengine testing. The solution was to pin the rubocop dependencies to the last working nightly versions:Checklist