- 
                Notifications
    You must be signed in to change notification settings 
- Fork 317
Add multicast support to XBAR #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            colluca
  wants to merge
  25
  commits into
  pulp-platform:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
colluca:multicast
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    To be improved: - 50% multicast AW throughput - Potential for combinational loops in mux
Multiple outstanding multicast transactions are allowed only if the slaves selected by these transactions are the same.
--------- Co-authored-by: Luca Colagrande <[email protected]> Co-authored-by: Raphael <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR adds multicast support to the AXI XBAR, such that write requests from a master can be multicast to multiple slaves.
To support multicast with low area overhead, we adopt the mask-based encoding proposed in https://arxiv.org/pdf/2502.19215.
In detail, this PR implements the following changes:
axi_mcast_demux_simpleimplements a superset of the functionality of theaxi_demux_simple, including all multicast capabilities, which require a few more signals on the interface, namelymst_is_mcast_oandmst_aw_commit_o. Soaxi_demux_simpleis rewritten as a wrapper aroundaxi_mcast_demux_simple, tying off unused ports and parameters.axi_mcast_muxandaxi_muxmodules, theaxi_mcast_xbar_unmuxedandaxi_xbar_unmuxedmodules, and theaxi_mcast_xbarandaxi_xbarmodules.axi_demux_id_countersmodule is moved to its own file, which is anyways good practice, and it would otherwise not be clear whether it should now belong toaxi_demux_simple.svoraxi_mcast_demux_simple.sv.ax_selectsignals from the address decoders. To eliminate this overhead (in the case of multicast it would even increase due to additional output signals from the decoders), we move the address decoders downstream of the spill registers in theaxi_mcast_demux_mappedmodule. The_mappedprefix is to identify a demux whose slaves are memory-mapped, i.e. that uses address decoders to generate theax_selectsignals. Since several modules use the demux with a non-address-basedax_selectsignal generation, theaxi_demuxmodule preserves the same interface and functionality as before, and does not wrap theaxi_mcast_demux_mappedmodule, unlike the other unicast and multicast IP pairs.