Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi/drivers #44

Merged
merged 1 commit into from
Aug 29, 2024
Merged

vi/drivers #44

merged 1 commit into from
Aug 29, 2024

Conversation

VictorIsachi
Copy link

Added FLL and Padframe drivers
Updated FLL test to use the driver
Fixed FLL propagation to SECD/RT clocks

Copy link
Collaborator

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good

@@ -400,7 +400,7 @@ module astral_wrap
.DIV_VALUE ( 100 ),
.ENABLE_CLOCK_IN_RESET( 1'b1 )
) i_rt_clk_div (
.clk_i ( clk_fll_out[3] ),
.clk_i ( clk_fll_out[4] ),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forse qua si può direttamente passare clk_fll_out[carfield_pkg::NumFll-1] così cambia dinamicamente col parametro, ma minor fix,

#define PLL_ADDR_SPACE 0x200
#define PLL_BASE_ADDRESS(id) (CAR_PLL_BASE_ADDRESS + (id+1)*PLL_ADDR_SPACE)
// FLL
#define FLL_BASE_ADDRESS 0x21003000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui si potrebbe usare direttamente *fll preso dai params.h ma anche questo minor fix.

#define FLL_INTEGR_REG 0x18

// Padframe
#define PADFRAME_BASE_ADDRESS 0x21000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui si potrebbe usare direttamente *padframel preso dai params.h ma anche questo minor fix.

@yvantor yvantor merged commit 2abbd27 into yt/thales-tapeout Aug 29, 2024
5 of 7 checks passed
@yvantor yvantor removed the request for review from alex96295 August 29, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants