Skip to content

Add Connection Status Listener. Add functions to Reconnect and Disconnect all subscriptions. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ endif()
FetchContent_Declare(
pubnub
GIT_REPOSITORY https://github.com/pubnub/c-core.git
GIT_TAG v5.0.0
GIT_TAG v5.0.2
GIT_SHALLOW TRUE
GIT_PROGRESS ON
SYSTEM
Expand All @@ -107,9 +107,9 @@ endif()

# TODO: this flag is okay until we release the Cpp-Chat as an independent library
if(${ENABLE_C_ABI})
target_compile_options(pubnub PUBLIC -DPUBNUB_SDK_VERSION_SUFFIX=\"/CA-Unity/0.4.4\")
target_compile_options(pubnub PUBLIC -DPUBNUB_SDK_VERSION_SUFFIX=\"/CA-Unity/0.5.0\")
else()
target_compile_options(pubnub PUBLIC -DPUBNUB_SDK_VERSION_SUFFIX=\"/CA-Unreal/0.4.0\")
target_compile_options(pubnub PUBLIC -DPUBNUB_SDK_VERSION_SUFFIX=\"/CA-Unreal/0.4.1\")
endif()

set(CCORE_COMPILE_OPTIONS -DPUBNUB_NTF_RUNTIME_SELECTION -DPUBNUB_USE_SUBSCRIBE_EVENT_ENGINE=1 -DPUBNUB_USE_SUBSCRIBE_V2=1 -DPUBNUB_CALLBACK_API=1 -DPUBNUB_SET_DNS_SERVERS=1 -DPUBNUB_USE_IPV6=1 -DPUBNUB_USE_LOG_CALLBACK=1)
Expand Down
4 changes: 4 additions & 0 deletions c_abi/include/c_chat.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -227,4 +227,8 @@ PN_CHAT_EXTERN PN_CHAT_EXPORT PnCResult pn_pam_set_auth_token(Pubnub::Chat* chat

PN_CHAT_EXTERN PN_CHAT_EXPORT PnCResult pn_pam_set_pubnub_origin(Pubnub::Chat* chat, const char* origin);

PN_CHAT_EXTERN PN_CHAT_EXPORT PnCTribool pn_chat_reconnect_subscriptions(Pubnub::Chat* chat);

PN_CHAT_EXTERN PN_CHAT_EXPORT PnCTribool pn_chat_disconnect_subscriptions(Pubnub::Chat* chat);

#endif // PN_CHAT_C_CHAT_HPP
24 changes: 24 additions & 0 deletions c_abi/src/c_chat.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -965,3 +965,27 @@ PnCResult pn_pam_set_pubnub_origin(Pubnub::Chat* chat, const char* origin) {
return PN_C_OK;
}


PnCTribool pn_chat_reconnect_subscriptions(Pubnub::Chat* chat)
{
try {
return chat->reconnect_subscriptions();
}
catch (std::exception& e) {
pn_c_set_error_message(e.what());

return PN_C_ERROR;
}
}

PnCTribool pn_chat_disconnect_subscriptions(Pubnub::Chat* chat)
{
try {
return chat->disconnect_subscriptions();
}
catch (std::exception& e) {
pn_c_set_error_message(e.what());

return PN_C_ERROR;
}
}
15 changes: 15 additions & 0 deletions include/pubnub_chat/chat.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ namespace Pubnub {
bool is_more;
};

struct ConnectionStatusData
{
/**Error details in case of ConnectionError.*/
Pubnub::String reason = "";
};



class Chat {
Expand Down Expand Up @@ -170,11 +176,20 @@ namespace Pubnub {
PN_CHAT_EXPORT void remove_thread_channel(const Pubnub::Message& message) const;

/* PAM */

PN_CHAT_EXPORT Pubnub::AccessManager access_manager() const;

/* LOG */

PN_CHAT_EXPORT void register_logger_callback(std::function<void(Pubnub::pn_log_level, const char*)> callback);

/* CONNECTION STATUS */

PN_CHAT_EXPORT void add_connection_status_listener(std::function<void(Pubnub::pn_connection_status status, Pubnub::ConnectionStatusData status_data)> connection_status_callback) const;
PN_CHAT_EXPORT void remove_connection_status_listener() const;
PN_CHAT_EXPORT bool reconnect_subscriptions() const;
PN_CHAT_EXPORT bool disconnect_subscriptions() const;

private:
Chat(const Pubnub::String& publish_key, const Pubnub::String& subscribe_key, const Pubnub::String& user_id, const ChatConfig& config);
void store_user_activity_timestamp() const;
Expand Down
6 changes: 6 additions & 0 deletions include/pubnub_chat/enums.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ enum pn_log_level {
Trace
};

enum pn_connection_status {
PCS_CONNECTION_ONLINE,
PCS_CONNECTION_OFFLINE,
PCS_CONNECTION_ERROR
};

}

#endif // PN_ENUMS_HPP
54 changes: 54 additions & 0 deletions src/application/callback_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@
#include "nlohmann/json.hpp"
#include "domain/parsers.hpp"
#include "message.hpp"
#include "enum_converters.hpp"
#include <algorithm>
#include <cstring>
#include <list>
#include <pubnub_helper.h>
#include <pubnub_subscribe_event_listener_types.h>
#include <pubnub_subscribe_event_listener.h>


using json = nlohmann::json;

Expand Down Expand Up @@ -738,3 +741,54 @@ CCoreCallbackData CallbackService::to_c_thread_messages_updates_callback(const s
this->callback_contexts.emplace_back(CallbackCtx{messages, message_service, message_update_callback})
};
}


void CallbackService::add_connection_status_listener(std::function<void(Pubnub::pn_connection_status status, Pubnub::ConnectionStatusData status_data)> listener)
{
if(nullptr == listener)
{
return;
}

this->status_listener = listener;

//If subscription status listener was already added, we just replace status_listener variable, no need to add it again to C-Core
if(status_listener_added)
{
return;
}

pubnub_subscribe_status_callback_t callback = +[](const pubnub_t *pb, const pubnub_subscription_status status, const pubnub_subscription_status_data_t status_data, void* _data)
{
CallbackService* CallbackServicebject = static_cast<CallbackService*>(_data);
if(!CallbackServicebject || !CallbackServicebject->status_listener)
{
return;
}

//Don't call the listener if the subscription status is changed - this type is not supported in Chat SDK
if(status == PNSS_SUBSCRIPTION_STATUS_SUBSCRIPTION_CHANGED)
{
return;
}
else
{
Pubnub::ConnectionStatusData data;
data.reason = pubnub_res_2_string(status_data.reason);
CallbackServicebject->status_listener(Pubnub::pn_subscription_status_to_connection_status(status), data);
}
};
this->status_listener_callback = callback;
auto guard = this->pubnub->lock();
guard->add_subscription_status_listener(status_listener_callback, this);
this->status_listener_added = true;
}

void CallbackService::remove_connection_status_listener()
{
auto guard = this->pubnub->lock();
guard->remove_subscription_status_listener(status_listener_callback, this);
this->status_listener_added = false;
this->status_listener = nullptr;
this->status_listener_callback = nullptr;
}
7 changes: 7 additions & 0 deletions src/application/callback_service.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ class CallbackService {

void broadcast_messages(std::vector<pubnub_v2_message> messages);

void add_connection_status_listener(std::function<void(Pubnub::pn_connection_status status, Pubnub::ConnectionStatusData status_data)> listener);
void remove_connection_status_listener();

CCoreCallbackData to_c_message_callback(std::weak_ptr<const ChatService> chat_service, std::function<void(Pubnub::Message)> message_callback);
CCoreCallbackData to_c_channel_update_callback(Pubnub::Channel channel, std::shared_ptr<const ChannelService> chat_service, std::function<void(Pubnub::Channel)> channel_update_callback);
CCoreCallbackData to_c_channels_updates_callback(const std::vector<Pubnub::Channel>& channels, std::shared_ptr<const ChannelService> chat_service, std::function<void(std::vector<Pubnub::Channel>)> channel_update_callback);
Expand Down Expand Up @@ -115,6 +118,10 @@ class CallbackService {
std::thread callback_thread;
std::atomic<bool> thread_run_flag;
std::list<std::any> callback_contexts;

std::function<void(Pubnub::pn_connection_status, Pubnub::ConnectionStatusData)> status_listener;
pubnub_subscribe_status_callback_t status_listener_callback;
bool status_listener_added = false;
};

#endif // PN_CHAT_CALLBACK_SERVICE_HPP
22 changes: 21 additions & 1 deletion src/application/chat_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,24 @@ std::shared_ptr<Subscription> ChatService::listen_for_events(const Pubnub::Strin
void ChatService::register_logger_callback(std::function<void(Pubnub::pn_log_level, const char*)> callback) const
{
logger.register_logging_callback(callback);
}
}

void ChatService::add_connection_status_listener(std::function<void(Pubnub::pn_connection_status status, Pubnub::ConnectionStatusData status_data)> connection_status_callback) const
{
this->callback_service->add_connection_status_listener(connection_status_callback);
}

void ChatService::remove_connection_status_listener() const
{
this->callback_service->remove_connection_status_listener();
}

bool ChatService::reconnect_subscriptions() const
{
return this->pubnub->lock()->reconnect_subscriptions();
}

bool ChatService::disconnect_subscriptions() const
{
return this->pubnub->lock()->disconnect_subscriptions();
}
5 changes: 5 additions & 0 deletions src/application/chat_service.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ class ChatService : public std::enable_shared_from_this<ChatService>

std::shared_ptr<CallbackService> callback_service;

void add_connection_status_listener(std::function<void(Pubnub::pn_connection_status status, Pubnub::ConnectionStatusData status_data)> connection_status_callback) const;
void remove_connection_status_listener() const;
bool reconnect_subscriptions() const;
bool disconnect_subscriptions() const;


private:
ThreadSafePtr<PubNub> pubnub;
Expand Down
20 changes: 20 additions & 0 deletions src/application/enum_converters.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
#include "enums.hpp"
#include <cstdint>

extern "C" {
#include <pubnub_subscribe_event_engine_types.h>
}


namespace Pubnub
{
Expand Down Expand Up @@ -136,6 +140,22 @@ static inline pubnub_chat_event_type chat_event_type_from_string(Pubnub::String
throw std::invalid_argument("can't convert chat_event_type_string to pubnub_chat_event_type");
}

static inline Pubnub::pn_connection_status pn_subscription_status_to_connection_status(const pubnub_subscription_status subscription_status)
{
switch(subscription_status)
{
case PNSS_SUBSCRIPTION_STATUS_CONNECTED:
return Pubnub::pn_connection_status::PCS_CONNECTION_ONLINE;
case PNSS_SUBSCRIPTION_STATUS_DISCONNECTED:
return Pubnub::pn_connection_status::PCS_CONNECTION_OFFLINE;
case PNSS_SUBSCRIPTION_STATUS_CONNECTION_ERROR:
return Pubnub::pn_connection_status::PCS_CONNECTION_ERROR;
case PNSS_SUBSCRIPTION_STATUS_DISCONNECTED_UNEXPECTEDLY:
return Pubnub::pn_connection_status::PCS_CONNECTION_ERROR;
default:
return Pubnub::pn_connection_status::PCS_CONNECTION_ERROR;
}
}
}

#endif // PN_ENUM_CONVERTERS_HPP
1 change: 0 additions & 1 deletion src/domain/message_entity.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ std::vector<std::pair<MessageEntity::MessageTimetoken, MessageEntity>> MessageEn

MessageEntity MessageEntity::edit_text(const Pubnub::String& text, const Pubnub::String& timetoken) const {
MessageEntity new_message_entity = *this;
new_message_entity.text = text;

Pubnub::MessageAction message_action;
message_action.type = Pubnub::pubnub_message_action_type::PMAT_Edited;
Expand Down
25 changes: 24 additions & 1 deletion src/infra/pubnub.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -846,4 +846,27 @@ int PubNub::set_pubnub_origin(const Pubnub::String origin)
void PubNub::set_logging_callback(void (*callback)(enum pubnub_log_level log_level, const char* message))
{
pubnub_set_log_callback(callback);
}
}

void PubNub::add_subscription_status_listener(pubnub_subscribe_status_callback_t callback, void* user_data)
{
pubnub_subscribe_add_status_listener(this->long_poll_context.get(), callback, user_data);
}

void PubNub::remove_subscription_status_listener(pubnub_subscribe_status_callback_t callback, void* user_data)
{
pubnub_subscribe_remove_status_listener(this->long_poll_context.get(), callback, user_data);
}

bool PubNub::reconnect_subscriptions()
{
auto result = pubnub_reconnect(this->long_poll_context.get(), nullptr);
return result == PNR_OK;
}

bool PubNub::disconnect_subscriptions()
{
auto result = pubnub_disconnect(this->long_poll_context.get());
return result == PNR_OK;
}

10 changes: 6 additions & 4 deletions src/infra/pubnub.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,8 @@ extern "C" {

namespace Pubnub
{
// class Message;
// class User;
// class Channel;
class Chat;
// class Membership;
struct ConnectionStatusData;
}
// TODO: format file
class PubNub {
Expand Down Expand Up @@ -79,6 +76,11 @@ class PubNub {

void set_logging_callback(void (*callback)(enum pubnub_log_level log_level, const char* message));

void add_subscription_status_listener(pubnub_subscribe_status_callback_t callback, void* user_data);
void remove_subscription_status_listener(pubnub_subscribe_status_callback_t callback, void* user_data);
bool reconnect_subscriptions();
bool disconnect_subscriptions();

private:
void await_and_handle_error(pubnub_res result);
bool is_subscribed_to_channel(const Pubnub::String channel);
Expand Down
20 changes: 20 additions & 0 deletions src/presentation/chat.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,26 @@ Pubnub::User Chat::create_user_for_init_chat(const Pubnub::String& user_id, cons
return this->user_service->create_user(user_id, user_data, true);
}

void Chat::add_connection_status_listener(std::function<void(Pubnub::pn_connection_status status, Pubnub::ConnectionStatusData status_data)> connection_status_callback) const
{
this->chat_service->add_connection_status_listener(connection_status_callback);
}

bool Chat::reconnect_subscriptions() const
{
return this->chat_service->reconnect_subscriptions();
}

void Chat::remove_connection_status_listener() const
{
this->chat_service->remove_connection_status_listener();
}

bool Chat::disconnect_subscriptions() const
{
return this->chat_service->disconnect_subscriptions();
}

#ifdef PN_CHAT_C_ABI

const ChatService* Chat::get_chat_service() const {
Expand Down