Add Connection Status Listener. Add functions to Reconnect and Disconnect all subscriptions. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavrax
reviewed
May 30, 2025
src/infra/pubnub.cpp
Outdated
Comment on lines
866
to
885
| { | ||
| PubNub* PubnubObject = static_cast<PubNub*>(_data); | ||
| if(!PubnubObject || !PubnubObject->status_listener) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| //Don't call the listener if the subscription status is changed - this type is not supported in Chat SDK | ||
| if(status == PNSS_SUBSCRIPTION_STATUS_SUBSCRIPTION_CHANGED) | ||
| { | ||
| return; | ||
| } | ||
| else | ||
| { | ||
| Pubnub::ConnectionStatusData data; | ||
| data.reason = pubnub_res_2_string(status_data.reason); | ||
| PubnubObject->status_listener(PubNub::pn_subscription_status_to_connection_status(status), data); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Shouldn't it be a part of the CallbackService?
There was a problem hiding this comment.
Moved to CallbackService
Xavrax
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add(subscribe): Add Connection Status Listener, so user can react to connection errors.
add(subscribe): Add functions to Reconnect and Disconnect all subscriptions.