Collapsable banners for survey annoucement #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Wineshuga, thanks for raising the PR! I'm not a front-end engineer, but the preview showed the behavior I wanted to see ❤️. There are some things we need to clean up first, though:
It looks like @IsabellePinheiro raised #2629, but the banner is only visible on the index page. Isabelle, since you know more about front-end code than I do, could you review this PR here? |
Signed-off-by: Wineshuga <[email protected]>
|
Thank you, @ArthurSens, for the helpful feedback. I've removed the unrelated commits that were mistakenly included and also cleaned up the changes caused by my IDE’s automatic linting. Please let me know if there's anything else you'd like me to adjust. |
|
Thank you, let's ship it! |
|
Urgh, for some reason it didn't work well when deployed. I'm looking for extra help here 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new banner feature across the website. The changes involve adding the banner's HTML structure, styling, and functionality.
I found this open issue (#2625), and it looked like something I could do, so I decided to give it a try. I would appreciate some feedback.
Banner Feature Implementation:
layouts/banner.htmlwith a survey link and a close button.layouts/header.html.hideBannerJavaScript function inlayouts/footer.htmlto allow users to close the banner.Screenshot