-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4534] Support filtering with multiple values #4846
Merged
samdoran
merged 5 commits into
main
from
COST-3394/COST-4534-support-multiple-filters-per-field
Jan 8, 2024
Merged
[COST-4534] Support filtering with multiple values #4846
samdoran
merged 5 commits into
main
from
COST-3394/COST-4534-support-multiple-filters-per-field
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4846 +/- ##
=====================================
Coverage 94.0% 94.0%
=====================================
Files 365 365
Lines 30288 30288
Branches 3603 3603
=====================================
Hits 28463 28463
Misses 1162 1162
Partials 663 663 |
c4e4525
to
891c5f6
Compare
891c5f6
to
0168225
Compare
Change detection isn't finding any changed files, so tests are not running and no coverage report is being generated. 😕 |
1f53d6d
to
378a471
Compare
e4beebe
to
dda3102
Compare
myersCody
previously approved these changes
Jan 5, 2024
dda3102
to
a326643
Compare
The Django Test client will urlencode the parameters
We can’t use it yet.
a326643
to
1ef695f
Compare
myersCody
approved these changes
Jan 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4534
Description
Support multiple filter values for the
project
andgroup
fields on the cost groups APITesting