Skip to content

Commit

Permalink
Support filtering with multiple values
Browse files Browse the repository at this point in the history
  • Loading branch information
samdoran committed Dec 21, 2023
1 parent 4ec522a commit c4e4525
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions koku/api/settings/cost_groups/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@
from api.report.serializers import FilterSerializer
from api.report.serializers import OrderSerializer
from api.report.serializers import ReportQueryParamSerializer
from api.report.serializers import StringOrListField
from reporting.provider.ocp.models import OCPProject
from reporting.provider.ocp.models import OpenshiftCostCategory


class CostGroupFilterSerializer(FilterSerializer):
"""Serializer for Cost Group Settings."""

project = serializers.CharField(required=False)
group = serializers.CharField(required=False)
project = StringOrListField(child=serializers.CharField(), required=False)
group = StringOrListField(child=serializers.CharField(), required=False)
default = serializers.BooleanField(required=False)


Expand Down
2 changes: 1 addition & 1 deletion koku/api/settings/test/cost_groups/test_serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def test_invalid_serializer_data(self):
self.assertFalse(serializer.is_valid())

def test_serialization(self):
instance_data = {"project": "example_project", "group": "example_group", "default": True}
instance_data = {"project": ["example_project"], "group": ["example_group"], "default": True}
serializer = CostGroupFilterSerializer(instance_data)
self.assertEqual(serializer.data, instance_data)

Expand Down

0 comments on commit c4e4525

Please sign in to comment.