fix: prevent noSmooth crash on p5.Graphics (resolves #8264) #8286
+53
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8264
Changes:
This PR fixes a crash when calling
noSmooth()on ap5.Graphicsobject in p5.js 2.0, which previously resulted in:What was done:
src/shape/attributes.jsto safely route throughrenderer.setSmoothing(false)when available.drawingContext.imageSmoothingEnabledfor cases wheresetSmoothingorsetAttributesdo not exist.noSmooth()works consistently on:Manual test pages added:
test/manual/noSmooth/canvas-2d.htmltest/manual/noSmooth/graphics-webgl.htmlThese test pages verify that
noSmooth()runs without errors and logs success messages in the console.Screenshots of the change:
Console output after fix:
Main Canvas (2D):
Main Canvas: noSmooth OKWebGL p5.Graphics:
WebGL p5.Graphics: noSmooth OKNo crashes, no TypeErrors.
PR Checklist
npm run lintpasses