[p5.js 2.0 Bug Report]: "TypeError: this.setAttributes is not a function" when calling noSmooth on a p5.Graphics object

[nking07049925]

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• Build process
• Unit testing
• Internationalization
• Friendly errors
• Other (specify if possible)

p5.js version

>=2.0.0

Web browser and version

Chromium 142.0.7444.60

Operating system

Windows 11

Steps to reproduce this

Steps:

Calling noSmooh on a p5.Graphics object results in the "TypeError: this.setAttributes is not a function" error.
Doesn't matter if called in setup or in draw. Doesn't reproduce on pre 2.0 versions.

Snippet:

function setup() {
  createCanvas(100, 100, WEBGL);
  const graphics = createGraphics(100, 100, WEBGL);
  graphics.noSmooth();
}

[nking07049925]

In my specific case I was trying to implement color-based object selection (rendering shapes with color corresponding to their IDs).
The main canvas needs to stay anti-aliased as normal, but the off-screen buffer has to be aliased to preserve shape color IDs.

[Harsh16gupta]

Hi, I would like to work on this issue.

[ayushman1210]

Hi maintainer i would like to work on it please assign it to me !!

[Rudrxxx]

Hi! I’ve submitted a PR that fixes this issue.

PR: #8286
It prevents the noSmooth() crash on p5.Graphics by safely routing through
setSmoothing() when available and falling back when not.

Works for both:

• Main canvas (2D)
• p5.Graphics 2D/WebGL

Manual test pages included and tested.

Let me know if any changes are needed. Thanks!

[davepagurek]

Thanks @nking07049925! I'm going to close this issue just because I think it's a duplicate of this one: #8170

I think a solution for this shouldn't actually touch the implementations of noSmooth, but rather needs to address the larger problem discussed in that issue where not all state that used to be on p5.Graphics in 1.x is on there any more, and we don't (yet) have a way to clearly specify in a module or addon which should be on both.