Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make lookup-any-sanity-checks optional in halo2_proofs #358

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix: make lookup-any-sanity-checks optional in halo2_proofs #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
513fef0
fix: make lookup-any-sanity-checks optional in halo2_proofs
ed255 Jun 27, 2024
eaaefe1
fix: bad lookup tests only when feature
ed255 Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions halo2_frontend/src/dev.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,6 +1495,7 @@ mod tests {
);
}

#[cfg(feature = "lookup-any-sanity-checks")]
#[test]
#[should_panic(
expected = "pair of tagging expressions(query of the tag columns or mutiple query combinations) should be included"
Expand Down Expand Up @@ -1578,6 +1579,7 @@ mod tests {
.unwrap();
}

#[cfg(feature = "lookup-any-sanity-checks")]
#[test]
#[should_panic(expected = "all table expressions need selector/fixed query for tagging")]
fn bad_lookup_any_no_fixed_col_or_selector() {
Expand Down Expand Up @@ -1652,6 +1654,7 @@ mod tests {
.unwrap();
}

#[cfg(feature = "lookup-any-sanity-checks")]
#[test]
#[should_panic(
expected = "all table expressions contain only fixed query, should use `lookup` api instead of `lookup_any`"
Expand Down
4 changes: 2 additions & 2 deletions halo2_proofs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ harness = false

[dependencies]
halo2_middleware = { path = "../halo2_middleware" }
halo2_backend = { path = "../halo2_backend" }
halo2_frontend = { path = "../halo2_frontend" }
halo2_backend = { path = "../halo2_backend", default-features = false }
halo2_frontend = { path = "../halo2_frontend", default-features = false }
halo2curves = { version = "0.6.1", default-features = false }
rand_core = { version = "0.6", default-features = false, features = ["getrandom"] }
plotters = { version = "0.3.0", default-features = false, optional = true }
Expand Down
Loading