Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make lookup-any-sanity-checks optional in halo2_proofs #358

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

ed255
Copy link
Member

@ed255 ed255 commented Jun 27, 2024

halo2_proofs was importing halo2_frontend with the default features, so there was no way to disable lookup-any-sanity-checks when using halo2_proofs.

Now halo2_proofs imports halo2_frontend without default features, and the dependencies features are completely controlled by the user via the halo2_proofs features. I did the same for halo2_backend to achieve the same level of control.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (445d1da) to head (eaaefe1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          84       84           
  Lines       17750    17750           
=======================================
  Hits        14670    14670           
  Misses       3080     3080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ed255 ed255 requested a review from guorong009 June 27, 2024 14:53
Copy link

@guorong009 guorong009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ed255 ed255 merged commit bc857a7 into main Jun 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants