Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include shuffles in PinnedConstraintSystem::fmt #195

Closed
wants to merge 2 commits into from
Closed

Include shuffles in PinnedConstraintSystem::fmt #195

wants to merge 2 commits into from

Conversation

therealyingtong
Copy link

No description provided.

han0110
han0110 approved these changes Aug 24, 2023
View reviewed changes
Copy link

@han0110 han0110 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch.

(the clippy error should be fixed after #192 is merged)

@han0110
Copy link

han0110 commented Sep 6, 2023

Just realized the change might lead to different transcript_repr even the circuit doesn't use shuffle, so I think to keep backward compatability we need to skip the shuffle field when it's empty.

han0110
han0110 requested changes Sep 6, 2023
View reviewed changes
halo2_proofs/src/plonk/circuit.rs Outdated Show resolved Hide resolved
@han0110 han0110 mentioned this pull request Nov 10, 2023
Merged
@CPerezz CPerezz mentioned this pull request Nov 10, 2023
Closed
@CPerezz @han0110
Update halo2_proofs/src/plonk/circuit.rs
ec12916 
Address @han0110's suggestions

Co-authored-by: Han <[email protected]>
CPerezz
CPerezz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CPerezz
Copy link
Member

CPerezz commented Nov 10, 2023

Closing as @han0110 already cherry-picked this in #226

@CPerezz CPerezz closed this Nov 10, 2023
@guorong009 guorong009 mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@han0110 han0110 han0110 requested changes

@CPerezz CPerezz CPerezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@therealyingtong @han0110 @CPerezz