patch: include shuffles in transcript, even when empty

[guorong009]

Description

• Add the shuffles to PinnedConstraintSystem::fmt, even when empty

Related issues

• Resolve Include shuffle within transcript when empty prior to a new major version release #227
  (Originated from Include shuffles in PinnedConstraintSystem::fmt #195)

Changes

• remove the empty check condition of shuffles in PinnedConstraintSystem::fmt
• update the plonk_api test

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (b4d1c4c) to head (2e6a7d6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   81.89%   81.89%   -0.01%     
==========================================
  Files          82       82              
  Lines       17010    17008       -2     
==========================================
- Hits        13930    13928       -2     
  Misses       3080     3080              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[han0110]

LGTM!

A small note: since any change to this function makes the transcript_repr different, I think it'd be good to also includes other conditionally debugged fields in futher PRs before the next release, to avoid needs of rotating vk.

[ed255]

As a reminder, in the latest release we had vk version 0x03:

halo2/halo2_proofs/src/plonk.rs

Line 64 in 73408a1

const VERSION: u8 = 0x03;

Currently in main (not yet released) we have version 0x04:

halo2/halo2_backend/src/plonk.rs

Line 58 in b4d1c4c

const VERSION: u8 = 0x04;

So there's no need to bump the vk version and we can use 0x04 for the next release.

[ed255]

LGTM!