-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: avoid virtual datasets whenever possible #295
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,19 @@ def create_dataset( | |
Virtual datasets are created when the table database is different from the main | ||
database, for systems that support cross-database queries (Trino, BigQuery, etc.) | ||
""" | ||
kwargs = { | ||
"database": database["id"], | ||
"catalog": model["database"], | ||
"schema": model["schema"], | ||
"table_name": model.get("alias") or model["name"], | ||
} | ||
try: | ||
# try to create dataset with catalog | ||
return client.create_dataset(**kwargs) | ||
except SupersetError as ex: | ||
if not no_catalog_support(ex): | ||
raise ex | ||
|
||
url = make_url(database["sqlalchemy_uri"]) | ||
if model_in_database(model, url): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. then avoid this |
||
kwargs = { | ||
|
@@ -91,6 +104,32 @@ def create_dataset( | |
return client.create_dataset(**kwargs) | ||
|
||
|
||
def no_catalog_support(ex: SupersetError) -> bool: | ||
""" | ||
Return if the error is due to a lack of catalog support. | ||
|
||
The errors payload looks like this: | ||
|
||
[ | ||
{ | ||
"message": json.dumps({"message": {"catalog": ["Unknown field."]}}), | ||
"error_type": "UNKNOWN_ERROR", | ||
"level": ErrorLevel.ERROR, | ||
}, | ||
] | ||
|
||
""" | ||
for error in ex.errors: | ||
try: | ||
message = json.loads(error["message"]) | ||
if "Unknown field." in message["message"]["catalog"]: | ||
return True | ||
except Exception: # pylint: disable=broad-except | ||
pass | ||
|
||
return False | ||
betodealmeida marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
def get_or_create_dataset( | ||
client: SupersetClient, | ||
model: ModelSchema, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just delete the
catalog
key here (del kwargs["catalog"]
)