chore: avoid virtual datasets whenever possible #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
bye-virtual-datasets
branch
3 times, most recently
from
e7b70c5
to
6d8d25b
Compare
betodealmeida
changed the title
betodealmeida
force-pushed
the
bye-virtual-datasets
branch
from
6d8d25b
to
c75ab5e
Compare
Vitor-Avila
reviewed
May 28, 2024
Vitor-Avila
reviewed
May 28, 2024
| except SupersetError as ex: | ||
| if not no_catalog_support(ex): | ||
| raise ex | ||
|
|
There was a problem hiding this comment.
You could just delete the catalog key here (del kwargs["catalog"])
Vitor-Avila
reviewed
May 28, 2024
| except SupersetError as ex: | ||
| if not no_catalog_support(ex): | ||
| raise ex | ||
|
|
||
| url = make_url(database["sqlalchemy_uri"]) | ||
| if model_in_database(model, url): |
There was a problem hiding this comment.
then avoid this if/else and have a single if not model_in_database(model, url) with kwargs["sql"] = f"SELECT * FROM {source}" (and the remaining logic that's specific for virtual datasets)
Vitor-Avila
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With SIP-95 implemented we don't need virtual datasets anymore, yay!
Note: ideally this still requires testing with a real project, and also for the SIP-95 branch to be deployed at Preset.