Monobuild changes #588
Merged
Monobuild changes #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
monobuild-changes
branch
3 times, most recently
from
fc45938 to
777de4b
Compare
hanno-becker
reviewed
Nov 3, 2025
hanno-becker
reviewed
Nov 3, 2025
hanno-becker
reviewed
Nov 3, 2025
hanno-becker
reviewed
Nov 3, 2025
hanno-becker
reviewed
Nov 3, 2025
hanno-becker
requested changes
Nov 3, 2025
There was a problem hiding this comment.
Looks very good, thanks a lot @mkannwischer esp. for the clean and review-able structure of this PR.
Two smaller points:
poly_chknormis generic and should live inpoly.[ch], unless I'm overlooking something?- Some typos in the commit message of 89428ff that you could fix while at it.
mkannwischer
force-pushed
the
monobuild-changes
branch
from
777de4b to
d959b41
Compare
hanno-becker
approved these changes
Nov 3, 2025
#532 introduced poly_kl.c for polynomial functions that depend on the parameter set. However, no separate header was introduced. A separate header is required for the monobuild to be able to undefine parameter-specific symbols. This commit adds the poly_kl.h header. Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
To avoid symbol clashes during SCU-builds, common.h should not be defining any symbols that are not undefined at the end of the SCU files. The only symbol violating this is mld_zeroize. We instead move that function to ct.h Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Symbols in poly_kl need to include the parameter set in the namespace to enable SCU builds. Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
monobuild-changes
branch
from
d959b41 to
5dc659b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the requires changes to the ML-DSA sources to enable the monobuild which will be added in #574.