Autogenerate mldsa_native.c and add monobuild examples #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
monobuild
branch
9 times, most recently
from
ae02aad to
68fa08d
Compare
mkannwischer
force-pushed
the
monobuild
branch
3 times, most recently
from
0e16e2a to
66b31fb
Compare
Merged
mkannwischer
force-pushed
the
monobuild
branch
from
66b31fb to
d566b9d
Compare
mkannwischer
changed the title
mkannwischer
force-pushed
the
monobuild
branch
5 times, most recently
from
ddeaad3 to
1557cdb
Compare
hanno-becker
requested changes
Nov 3, 2025
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
make clean should clean all examples. Otherwise, LGTM
mkannwischer
force-pushed
the
monobuild
branch
from
1557cdb to
da07fd1
Compare
Contributor
Author
mkannwischer
force-pushed
the
monobuild
branch
from
f4f1ba3 to
1758365
Compare
mkannwischer
force-pushed
the
monobuild
branch
3 times, most recently
from
85a9bf2 to
3ad3089
Compare
hanno-becker
reviewed
Nov 4, 2025
ML-DSA-44 and ML-DSA_86 only use mld_poly_uniform_gamma1_4x, while ML-DSA-65 requires both mld_poly_uniform_gamma1_4x and mld_poly_uniform_gamma1. Hence, mld_poly_uniform_gamma1 should only be included in builds for ML-DSA-65 to enable marking all internal functions as static in a multi-level monobuild. Signed-off-by: Matthias J. Kannwischer <[email protected]>
This commit ports the auto-generation script for mldsa_native.c from mlkem-native. This file will be used in subsequent commits to demonstrate a monolothic build. Signed-off-by: Matthias J. Kannwischer <[email protected]>
This commit adds a new example to mldsa-native ported from mlkem-native. It demonstrated how to build a single instance of mldsa-native in a single compilation unit. Signed-off-by: Matthias J. Kannwischer <[email protected]>
This ports the monolithic_build_multilevel from mlkem-native. This examples demonstrated how to build multiple instances of mldsa-native in a single compilation unit Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
The C90 tests were not functional before as make clean would not clean the example code. The previous commit fixed that and revealed some C90 issues in the example code. This commit fixes the C90 issues. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
monobuild
branch
from
3ad3089 to
44ab709
Compare
hanno-becker
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.